linux-kernel - Re: [PATCH 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201704061239.23151.jbe@pengutronix.de>
Date:   Thu, 6 Apr 2017 12:39:22 +0200
From:   Juergen Borleis <jbe@...gutronix.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        f.fainelli@...il.com, kernel@...gutronix.de,
        vivien.didelot@...oirfairelinux.com, davem@...emloft.net
Subject: Re: [PATCH 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303

Hi Andrew,

On Wednesday 05 April 2017 20:12:32 Andrew Lunn wrote:
> [...]
> >  drivers/net/phy/lan9303-core.c | 924 +++++++++++++++++++++++++++++++++++++++++
> >  drivers/net/phy/lan9303.h      |  21 +
>
> drivers/net/dsa please.

Done in v2.

> One general comment. I'm assuming parts of this code comes from
> openwrt swconfig. In swconfig, i think they consider switches to be
> part of the PHY layer. In DSA, switches are switches, PHYs are
> PHYs. So the naming in this driver needs to reflect this.

And the LAN9303 is a switch with built-in PHYs :)

Juergen

-- 
Pengutronix e.K.                             | Juergen Borleis             |
Industrial Linux Solutions                   | http://www.pengutronix.de/  |