linux-kernel - [PATCH 1/2] ASoC: codec: wm8960: Stop when a matching PLL freq is found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1491479514-24862-2-git-send-email-daniel.baluta@nxp.com>
Date:   Thu, 6 Apr 2017 14:51:53 +0300
From:   Daniel Baluta <daniel.baluta@....com>
To:     <alsa-devel@...a-project.org>
CC:     <lgirdwood@...il.com>, <broonie@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>, <linux-kernel@...r.kernel.org>,
        <patches@...nsource.wolfsonmicro.com>,
        <ckeepax@...nsource.wolfsonmicro.com>, <shengjiu.wang@....com>,
        <viorel.suman@....com>, <mihai.serban@....com>
Subject: [PATCH 1/2] ASoC: codec: wm8960: Stop when a matching PLL freq is found

When a matching PLL freq is found, searching continues even this is
not necessary. The problem was introduced with the following refactoring
commit 84fdc00d519ffd ("ASoC: codec: wm9860: Refactor PLL out freq search)

Signed-off-by: Daniel Baluta <daniel.baluta@....com>
---
 sound/soc/codecs/wm8960.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
index 36c8454..ace69da 100644
--- a/sound/soc/codecs/wm8960.c
+++ b/sound/soc/codecs/wm8960.c
@@ -724,7 +724,11 @@ int wm8960_configure_pll(struct snd_soc_codec *codec, int freq_in,
 					break;
 				}
 			}
+			if (k != ARRAY_SIZE(bclk_divs))
+				break;
 		}
+		if (j != ARRAY_SIZE(dac_divs))
+			break;
 	}
 
 	if (*bclk_idx != -1)
-- 
2.7.4