linux-kernel - Re: [PATCH v3] pwm: rockchip: State of pwm clock should synchronize with pwm enabled state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170406131047.GA8438@ulmo.ba.sec>
Date:   Thu, 6 Apr 2017 15:10:47 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     David Wu <david.wu@...k-chips.com>
Cc:     boris.brezillon@...e-electrons.com, briannorris@...omium.org,
        heiko@...ech.de, dianders@...omium.org, b.galvani@...il.com,
        caesar.wang@...k-chips.com, huangtao@...k-chips.com,
        linux-rockchip@...ts.infradead.org, linux-pwm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH v3] pwm: rockchip: State of pwm clock should synchronize
 with pwm enabled state

On Wed, Mar 01, 2017 at 07:10:55PM +0800, David Wu wrote:
> From: "david.wu" <david.wu@...k-chips.com>

You might want to set up git to use the correct author.

> If the pwm was not enabled at uboot loader, pwm could not work for clock
> always disabled at pwm driver. The pwm clock is enabled at beginning of
> pwm_apply(), but disabled at end of pwm_apply().
> 
> If the pwm was enabled at uboot loader, pwm clock is always enabled unless
> closed by ATF. The pwm-backlight might turn off the power at early suspend,
> should disable pwm clock for saving power consume.
> 
> It is important to provide opportunity to enable/disable clock at pwm driver,
> the pwm consumer should ensure correct order to call pwm enable/disable, and
> pwm driver ensure state of pwm clock synchronized with pwm enabled state.

Please always use all-caps for abbreviations suchs as "PWM". I've fixed
up the commit message and applied this to for-4.11/fixes.

Thanks,
Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)