linux-kernel - Re: [PATCH] fpga fr br: fix warning for unexpected version number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAtXAHfxLX=t4tzOyD=KpP3Gc8WgncbtT1eu87RZ31OumLOUow@mail.gmail.com>
Date:   Wed, 5 Apr 2017 17:13:26 -0700
From:   Moritz Fischer <mdf@...nel.org>
To:     matthew.gerlach@...ux.intel.com
Cc:     Alan Tull <atull@...nel.org>, linux-fpga@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fpga fr br: fix warning for unexpected version number

Hi Matthew,

On Wed, Apr 5, 2017 at 3:25 PM,  <matthew.gerlach@...ux.intel.com> wrote:

>> Maybe you actually wanna bail out if you read a random other value
>> instead of what you
>> expect instead of printing a warning.
>
>
> I thought about making it an error if the version didn't match, but it was a
> dev_warn() before and that allowed folks to use the "old" driver with the
> new IP version.

Or some random other piece of logic in the FPGA that happens to be mapped
to that address ;-)

I agree we should've probably caught this in the initial review, but maybe we
should change it.

Cheers,

Moritz