linux-kernel - Re: [PATCH 4/4] net: dsa: LAN9303: add MDIO managed mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33d61a69-462f-dfb4-98f1-911882b0d466@gmail.com>
Date:   Thu, 6 Apr 2017 06:53:10 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, Juergen Borleis <jbe@...gutronix.de>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de, vivien.didelot@...oirfairelinux.com,
        davem@...emloft.net
Subject: Re: [PATCH 4/4] net: dsa: LAN9303: add MDIO managed mode support



On 04/05/2017 12:32 PM, Andrew Lunn wrote:
>> +static const struct of_device_id lan9303_mdio_of_match[] = {
>> +	{ .compatible = "smsc,lan9303" },
>> +	{ /* sentinel */ },
>> +};
>> +MODULE_DEVICE_TABLE(of, lan9303_mdio_of_match);
> 
> If i'm reading this right, i think you have the same compatible string
> for both the i2c and the mdio driver. Does that work? I've no idea.

This should not be a problem, actually, this does seem like the right
thing to do. The bus topology would solve the Linux device creation such
that you would probe either via mdio or i2c (or both) but through the
appropriate drivers' probe functions.
-- 
Florian