linux-kernel - Re: [Linux-cachefs] Variable fscache_cache_cleared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 06 Apr 2017 15:03:42 +0100
From:   David Howells <dhowells@...hat.com>
To:     Corcodel Marian <asd@...ian1000.go.ro>
Cc:     dhowells@...hat.com, linux-cachefs@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [Linux-cachefs] Variable fscache_cache_cleared_wq undefined!

Corcodel Marian <asd@...ian1000.go.ro> wrote:

> Hi on function fscache_object_destroyed may run with variable undefined when
> in not set CONFIG_FSCACHE
> 
> +void fscache_object_destroyed(struct fscache_cache *cache)
> +{
> +#ifdef CONFIG_FSCACHE
> +       if (atomic_dec_and_test(&cache->object_count))
> +               wake_up_all(&fscache_cache_cleared_wq);
> +#endif
> }

No one should be including linux/fscache-cache.h from code that's built when
CONFIG_FSCACHE is disabled.

David