linux-kernel - Re: [PATCH v2 1/2] pwm: loongson1: Add PWM driver for Loongson1 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170406161835.GA19312@ulmo.ba.sec>
Date:   Thu, 6 Apr 2017 18:18:35 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Yang Ling <gnaygnil@...il.com>
Cc:     Marcin Nowakowski <marcin.nowakowski@...tec.com>,
        Keguang Zhang <keguang.zhang@...il.com>,
        linux-kernel@...r.kernel.org, linux-pwm@...r.kernel.org,
        linux-mips@...ux-mips.org
Subject: Re: [PATCH v2 1/2] pwm: loongson1: Add PWM driver for Loongson1 SoC

On Wed, Feb 15, 2017 at 10:45:31PM +0800, Yang Ling wrote:
> Add support for the PWM controller present in Loongson1 family of SoCs.
> 
> Signed-off-by: Yang Ling <gnaygnil@...il.com>
> 
> ---
> V2:
>   Remove ls1x_pwm_channel.
>   Remove period_ns/duty_ns check.
>   Add return values check.
> ---
>  drivers/pwm/Kconfig         |   9 +++
>  drivers/pwm/Makefile        |   1 +
>  drivers/pwm/pwm-loongson1.c | 148 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 158 insertions(+)
>  create mode 100644 drivers/pwm/pwm-loongson1.c

Looks like this doesn't compile because it uses register definitions
from loongson1.h that aren't what the driver expects. Looks like the
driver wants parameterized ones, but those present in the kernel are
not.

Any plans on fixing that? How did you build-test this?

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)