linux-kernel - Re: [PATCH] format-security: move static strings to const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 6 Apr 2017 13:19:41 -0400
From:   Jes Sorensen <jes.sorensen@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] format-security: move static strings to const

On 04/05/2017 05:47 PM, Kees Cook wrote:
> While examining output from trial builds with -Wformat-security enabled,
> many strings were found that should be defined as "const", or as a char
> array instead of char pointer. This makes some static analysis easier,
> by producing fewer false positives.
>
> As these are all trivial changes, it seemed best to put them all in
> a single patch rather than chopping them up per maintainer.
>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  arch/arm/mach-omap2/board-n8x0.c                  |  2 +-
>  arch/mips/dec/prom/init.c                         |  6 +++---
>  arch/mips/kernel/traps.c                          |  4 ++--
>  drivers/char/dsp56k.c                             |  2 +-
>  drivers/cpufreq/powernow-k8.c                     |  3 ++-
>  drivers/gpu/drm/drm_fb_helper.c                   |  2 +-
>  drivers/net/ethernet/amd/atarilance.c             |  4 ++--
>  drivers/net/ethernet/amd/declance.c               |  2 +-
>  drivers/net/ethernet/amd/sun3lance.c              |  3 ++-
>  drivers/net/ethernet/cirrus/mac89x0.c             |  2 +-
>  drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h |  2 +-
>  drivers/net/ethernet/natsemi/sonic.h              |  2 +-
>  drivers/net/ethernet/toshiba/tc35815.c            |  2 +-
>  drivers/net/fddi/defxx.c                          |  2 +-
>  drivers/net/hippi/rrunner.c                       |  3 ++-
>  drivers/staging/most/mostcore/core.c              |  2 +-
>  drivers/tty/n_hdlc.c                              | 10 +++++-----
>  drivers/tty/serial/st-asc.c                       |  2 +-
>  net/decnet/af_decnet.c                            |  3 ++-
>  19 files changed, 31 insertions(+), 27 deletions(-)

rrunner.c changes look fine to me.

Jes