linux-kernel - Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after }.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4fe785d2-c7a8-2d5a-4a6d-1fbfe0e8bb89@gmail.com>
Date:   Thu, 6 Apr 2017 23:25:43 +0200
From:   Valerio G <valerio.click@...il.com>
To:     Joe Perches <joe@...ches.com>, gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after }.

Hi,

Thanks for the feedback. I re-submitted the patch as v2.

best
Valerio

Il 06/04/2017 01:57, Joe Perches ha scritto:
> On Wed, 2017-04-05 at 21:23 +0200, Valerio Genovese wrote:
>> This was reported by checkpatch.pl:
>> ERROR: space required after that close brace '}'
>>
>> Signed-off-by: Valerio Genovese <valerio.click@...il.com>
>> ---
>>  drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
>> index 2c398ca..5218f27 100644
>> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
>> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
>> @@ -31,7 +31,7 @@ typedef union _SEQUENCE_CONTROL{
>>  	struct {
>>  		u16	FragNum:4;
>>  		u16	SeqNum:12;
>> -	}field;
>> +	} field;
>>  }SEQUENCE_CONTROL, *PSEQUENCE_CONTROL;
> 
> What about the one on the next line?
> 
> $ ./scripts/checkpatch.pl -f drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h --types=spacing --terse
> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:29: WARNING: missing space after union definition
> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:34: ERROR: space required after that close brace '}'
> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:35: ERROR: space required after that close brace '}'
>