linux-kernel - Re: [PATCH 02/24] Add the ability to lock down access to the running kernel image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.20.1704070755010.27111@namei.org>
Date:   Fri, 7 Apr 2017 07:55:54 +1000 (AEST)
From:   James Morris <jmorris@...ei.org>
To:     David Howells <dhowells@...hat.com>
cc:     linux-kernel@...r.kernel.org, gnomes@...rguk.ukuu.org.uk,
        linux-efi@...r.kernel.org, matthew.garrett@...ula.com,
        gregkh@...uxfoundation.org, linux-security-module@...r.kernel.org,
        keyrings@...r.kernel.org
Subject: Re: [PATCH 02/24] Add the ability to lock down access to the running
 kernel image

On Thu, 6 Apr 2017, David Howells wrote:

> James Morris <jmorris@...ei.org> wrote:
> 
> > > +static __read_mostly bool kernel_locked_down;
> > 
> > How about marking this __ro_after_init if ALLOW_LOCKDOWN_LIFT is not 
> > configured?
> 
> I guess lock_kernel_down() would need to be __init also in that case.

Ideally, yes.

> 
> Also, the implementation of lift_kernel_lockdown() should be conditional on
> CONFIG_ALLOW_LOCKDOWN_LIFT.
> 
> David
> 

-- 
James Morris
<jmorris@...ei.org>