lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Apr 2017 10:30:12 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Richard Fitzgerald <rf@...nsource.wolfsonmicro.com> Cc: Alexandre Courbot <gnurou@...il.com>, Rob Herring <robh+dt@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Jason Cooper <jason@...edaemon.net>, Lee Jones <lee.jones@...aro.org>, Mark Brown <broonie@...nel.org>, "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>, "open list:WOLFSON MICROELECTRONICS DRIVERS" <patches@...nsource.wolfsonmicro.com>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 01/16] mfd: madera: Add register definitions for Cirrus Logic Madera codecs On Fri, Apr 7, 2017 at 10:27 AM, Linus Walleij <linus.walleij@...aro.org> wrote: > On Wed, Apr 5, 2017 at 12:07 PM, Richard Fitzgerald > <rf@...nsource.wolfsonmicro.com> wrote: > >> This patch adds a header file of register definitions for Cirrus >> Logic "Madera" class codecs. These codecs are all based off a common >> set of hardware IP so have a common register map (with a few minor >> device-to-device variations). These are complex devices with a large >> mber of features and so have a correspondingly large register set. >> The registers.h file has been auto-generated from the hardware register >> definitions, stripped down to only registers we need to access from >> the driver. >> >> Signed-off-by: Richard Fitzgerald <rf@...nsource.wolfsonmicro.com> > > This: > include/linux/mfd/madera/registers.h | 8832 ++++++++++++++++++++++++++++++++++ > > Get included in all subdrivers I suppose? > > So you are broadcasting 8800+ lines into every subdriver across the > entire kernel. > > Just the time spent in the preprocessor parsing this will affect compilation > time. Or maybe this is a necessary sacrifice to get the regmap cache centralized in MFD. I don't know. I feel stupid. I guess I should focus on "my" subsystems... Yours, Linus Walleij
Powered by blists - more mailing lists