linux-kernel - Re: [PATCH 35/38] Annotate hardware config module parameters in sound/drivers/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hzifs8v7m.wl-tiwai@suse.de>
Date:   Fri, 07 Apr 2017 10:42:37 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "David Howells" <dhowells@...hat.com>
Cc:     <linux-kernel@...r.kernel.org>, <alsa-devel@...a-project.org>,
        <gregkh@...uxfoundation.org>, <gnomes@...rguk.ukuu.org.uk>,
        "Jaroslav Kysela" <perex@...ex.cz>, <keyrings@...r.kernel.org>,
        <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH 35/38] Annotate hardware config module parameters in sound/drivers/

On Wed, 05 Apr 2017 19:01:59 +0200,
David Howells wrote:
> 
> When the kernel is running in secure boot mode, we lock down the kernel to
> prevent userspace from modifying the running kernel image.  Whilst this
> includes prohibiting access to things like /dev/mem, it must also prevent
> access by means of configuring driver modules in such a way as to cause a
> device to access or modify the kernel image.
> 
> To this end, annotate module_param* statements that refer to hardware
> configuration and indicate for future reference what type of parameter they
> specify.  The parameter parser in the core sees this information and can
> skip such parameters with an error message if the kernel is locked down.
> The module initialisation then runs as normal, but just sees whatever the
> default values for those parameters is.
> 
> Note that we do still need to do the module initialisation because some
> drivers have viable defaults set in case parameters aren't specified and
> some drivers support automatic configuration (e.g. PNP or PCI) in addition
> to manually coded parameters.
> 
> This patch annotates drivers in sound/drivers/.
> 
> Suggested-by: Alan Cox <gnomes@...rguk.ukuu.org.uk>
> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: Jaroslav Kysela <perex@...ex.cz>
> cc: Takashi Iwai <tiwai@...e.com>
> cc: alsa-devel@...a-project.org

The changes look fairly straightforward, so feel free to take my ack
for sound/* stuff:
  Acked-by: Takashi Iwai <tiwai@...e.de>


thanks,

Takashi