linux-kernel - Re: [PATCH v3 02/20] net: stmmac: add optional setup function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170407125138.GC15546@Red>
Date:   Fri, 7 Apr 2017 14:51:38 +0200
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     Giuseppe CAVALLARO <peppe.cavallaro@...com>
Cc:     robh+dt@...nel.org, mark.rutland@....com,
        maxime.ripard@...e-electrons.com, wens@...e.org,
        linux@...linux.org.uk, catalin.marinas@....com,
        will.deacon@....com, alexandre.torgue@...com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 02/20] net: stmmac: add optional setup function

On Mon, Apr 03, 2017 at 02:32:33PM +0200, Giuseppe CAVALLARO wrote:
> Hello Corentin
> 
> On 4/3/2017 11:14 AM, Corentin Labbe wrote:
> > Instead of adding more ifthen logic for adding a new mac_device_info
> > setup function, it is easier to add a function pointer to the function
> > needed.
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> > ---
> >   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +++-
> >   include/linux/stmmac.h                            | 3 +++
> >   2 files changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > index 43361f3..3beca41 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > @@ -3508,7 +3508,9 @@ static int stmmac_hw_init(struct stmmac_priv *priv)
> >   	struct mac_device_info *mac;
> >   
> >   	/* Identify the MAC HW device */
> > -	if (priv->plat->has_gmac) {
> > +	if (priv->plat->setup) {
> > +		mac = priv->plat->setup(priv);
> > +	} else if (priv->plat->has_gmac) {
> >   		priv->dev->priv_flags |= IFF_UNICAST_FLT;
> >   		mac = dwmac1000_setup(priv->ioaddr,
> >   				      priv->plat->multicast_filter_bins,
> > diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
> > index 3921cb9..dadd74b 100644
> > --- a/include/linux/stmmac.h
> > +++ b/include/linux/stmmac.h
> > @@ -144,6 +144,8 @@ struct stmmac_txq_cfg {
> >   	u32 prio;
> >   };
> >   
> > +struct stmmac_priv;
> > +
> >   struct plat_stmmacenet_data {
> >   	int bus_id;
> >   	int phy_addr;
> > @@ -177,6 +179,7 @@ struct plat_stmmacenet_data {
> >   	void (*fix_mac_speed)(void *priv, unsigned int speed);
> >   	int (*init)(struct platform_device *pdev, void *priv);
> >   	void (*exit)(struct platform_device *pdev, void *priv);
> > +	struct mac_device_info *(*setup)(struct stmmac_priv *priv);
> 
> In that case  I prefer to have void *priv as done for the other callbacks.
> I mean, keep the priv struct inside the driver part.
> 


Agree, I will change it

Thanks
Regards