linux-kernel - Re: [PATCH v3] clk: stm32h7: Add stm32h743 clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 7 Apr 2017 21:51:41 +0800
From:   kbuild test robot <lkp@...el.com>
To:     gabriel.fernandez@...com
Cc:     kbuild-all@...org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Nicolas Pitre <nico@...aro.org>, Arnd Bergmann <arnd@...db.de>,
        daniel.thompson@...aro.org, andrea.merello@...il.com,
        radoslaw.pietrzyk@...il.com, Lee Jones <lee.jones@...aro.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        gabriel.fernandez@...com, ludovic.barre@...com,
        olivier.bideau@...com, amelie.delaunay@...com
Subject: Re: [PATCH v3] clk: stm32h7: Add stm32h743 clock driver

Hi Gabriel,

[auto build test WARNING on clk/clk-next]
[also build test WARNING on v4.11-rc5 next-20170406]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/gabriel-fernandez-st-com/clk-stm32h7-Add-stm32h743-clock-driver/20170405-100654
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: arm-stm32_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/clk/clk-stm32h7.c: In function 'ready_gate_clk_disable':
>> drivers/clk/clk-stm32h7.c:250:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if (rgate->backup_domain && dbp_status)
     ^~
   drivers/clk/clk-stm32h7.c:253:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
      clk_gate_ops.disable(hw);
      ^~~~~~~~~~~~

vim +/if +250 drivers/clk/clk-stm32h7.c

   234		return bit_status;
   235	}
   236	
   237	static void ready_gate_clk_disable(struct clk_hw *hw)
   238	{
   239		struct clk_gate *gate = to_clk_gate(hw);
   240		struct stm32_ready_gate *rgate = to_ready_gate_clk(gate);
   241		int dbp_status;
   242		int bit_status;
   243		unsigned int timeout = RGATE_TIMEOUT;
   244	
   245		if (!ready_gate_clk_is_enabled(hw))
   246			return;
   247	
   248		dbp_status = is_enable_power_domain_write_protection();
   249	
 > 250		if (rgate->backup_domain && dbp_status)
   251			disable_power_domain_write_protection();
   252	
   253			clk_gate_ops.disable(hw);
   254	
   255		do {
   256			bit_status = !!(readl(gate->reg) & BIT(rgate->bit_rdy));
   257	
   258			if (bit_status)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (9580 bytes)