linux-kernel - Re: [PATCH 4/5] drivers: char: Replace printk with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170407154602.GB11575@kroah.com>
Date:   Fri, 7 Apr 2017 17:46:02 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Varsha Rao <rvarsha016@...il.com>
Cc:     Matthew Wilcox <mawilcox@...rosoft.com>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] drivers: char: Replace printk with pr_err.

On Fri, Apr 07, 2017 at 05:04:06PM +0530, Varsha Rao wrote:
> Replace printk with pr_err to fix the checkpatch issue.
> 
> Signed-off-by: Varsha Rao <rvarsha016@...il.com>
> ---
>  drivers/char/misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
> index 1312e29..c9cd1ea 100644
> --- a/drivers/char/misc.c
> +++ b/drivers/char/misc.c
> @@ -294,7 +294,7 @@ static int __init misc_init(void)
>  	return 0;
>  
>  fail_printk:
> -	printk("unable to get major %d for misc devices\n", MISC_MAJOR);
> +	pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);

Is pr_fmt properly set to use this?

thanks,

greg k-h