linux-kernel - Re: [PATCH 1/1] memory: tegra: fix fdc test bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1bfab352ccd1581882d6e82b6eb72cb4@codethink.com>
Date:   Fri, 07 Apr 2017 22:54:19 +0100
From:   Ben Dooks <ben.dooks@...ethink.co.uk>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     linux-kernel@...ts.codethink.co.uk, swarren@...dotorg.org,
        gnurou@...il.com, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] memory: tegra: fix fdc test bug

On 2017-04-07 18:43, Thierry Reding wrote:
> On Fri, Apr 07, 2017 at 06:28:20PM +0100, Ben Dooks wrote:
>> The fdc variable is a bool, taking the address of this will generally
>> produce true, thus skewing any users of the 
>> tegra_mc_set_latency_allowance
>> code.
>> 
>> Note, this does not seem to be producing a compiler warning. This was 
>> only
>> spotted as it meant a caller was seeing 3 times higher than expected
>> register results.
>> 
>> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
>> ---
>>  drivers/memory/tegra/mc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> What tree is this based on? I don't see this code anywhere in mainline.

Apologies, turns out this a vendor added function.

-- 
Ben