linux-kernel - Re: [PATCH] staging: goldfish: Add parenthesis around macros arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170408150338.GA16049@kroah.com>
Date:   Sat, 8 Apr 2017 17:03:38 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     aviyae <aviyae42@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: goldfish: Add parenthesis around macros
 arguments

On Thu, Mar 30, 2017 at 12:11:05AM +0300, aviyae wrote:
> Fix style issues by adding parenthesis around macros
> arguments
> 
> Signed-off-by: Aviya Erenfeld <aviyae42@...il.com>
> ---
>  drivers/staging/goldfish/goldfish_audio.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
> index bd55995..2bb1f27 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -61,10 +61,11 @@ struct goldfish_audio {
>  #define COMBINED_BUFFER_SIZE    ((2 * READ_BUFFER_SIZE) + \
>                                         (2 * WRITE_BUFFER_SIZE))
> 
> -#define AUDIO_READ(data, addr)         (readl(data->reg_base + addr))
> -#define AUDIO_WRITE(data, addr, x)     (writel(x, data->reg_base + addr))
> +#define AUDIO_READ(data, addr)         (readl((data)->reg_base + (addr)))
> +#define AUDIO_WRITE(data, addr, x)     (writel(x, (data)->reg_base + (addr)))
>  #define AUDIO_WRITE64(data, addr, addr2, x)    \
> -       (gf_write_dma_addr((x), data->reg_base + addr, data->reg_base + addr2))
> +       (gf_write_dma_addr((x), (data)->reg_base + (addr), \
> +       (data)->reg_base + (addr2)))

Your indentation here is odd, please fix up.

And is this really a needed change?

thanks,

greg k-h