linux-kernel - Re: [PATCH] net: netfilter: ipvs: Replace explicit NULL comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201704090633.AKZxFfWl%fengguang.wu@intel.com>
Date:   Sun, 9 Apr 2017 06:21:51 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
Cc:     kbuild-all@...org, wensong@...ux-vs.org,
        Simon Horman <horms@...ge.net.au>,
        Julian Anastasov <ja@....bg>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: netfilter: ipvs: Replace explicit NULL comparison

Hi Arushi,

[auto build test WARNING on ipvs-next/master]
[also build test WARNING on v4.11-rc5 next-20170407]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Arushi-Singhal/net-netfilter-ipvs-Replace-explicit-NULL-comparison/20170409-044710
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs-next.git master
config: i386-randconfig-x002-201715 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   net/netfilter/ipvs/ip_vs_proto.c: In function 'ip_vs_protocol_net_cleanup':
>> net/netfilter/ipvs/ip_vs_proto.c:350:3: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
      while (pd = ipvs->proto_data_table[i])
      ^~~~~
   net/netfilter/ipvs/ip_vs_proto.c: In function 'ip_vs_protocol_cleanup':
   net/netfilter/ipvs/ip_vs_proto.c:395:3: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
      while (pp = ip_vs_proto_table[i])
      ^~~~~

vim +350 net/netfilter/ipvs/ip_vs_proto.c

   334				goto cleanup;
   335		}
   336		return 0;
   337	
   338	cleanup:
   339		ip_vs_protocol_net_cleanup(ipvs);
   340		return ret;
   341	}
   342	
   343	void __net_exit ip_vs_protocol_net_cleanup(struct netns_ipvs *ipvs)
   344	{
   345		struct ip_vs_proto_data *pd;
   346		int i;
   347	
   348		/* unregister all the ipvs proto data for this netns */
   349		for (i = 0; i < IP_VS_PROTO_TAB_SIZE; i++) {
 > 350			while (pd = ipvs->proto_data_table[i])
   351				unregister_ip_vs_proto_netns(ipvs, pd);
   352		}
   353	}
   354	
   355	int __init ip_vs_protocol_init(void)
   356	{
   357		char protocols[64];
   358	#define REGISTER_PROTOCOL(p)			\

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (23059 bytes)