linux-kernel - Re: [PATCH] dmaengine: ioat: use setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 9 Apr 2017 11:04:02 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Geliang Tang <geliangtang@...il.com>
Cc:     Vinod Koul <vinod.koul@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: ioat: use setup_timer

On Sat, Apr 8, 2017 at 6:41 PM, Geliang Tang <geliangtang@...il.com> wrote:
> Use setup_timer() instead of init_timer() to simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> ---
>  drivers/dma/ioat/init.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
> index cc5259b..6ad4384 100644
> --- a/drivers/dma/ioat/init.c
> +++ b/drivers/dma/ioat/init.c
> @@ -760,9 +760,7 @@ ioat_init_channel(struct ioatdma_device *ioat_dma,
>         dma_cookie_init(&ioat_chan->dma_chan);
>         list_add_tail(&ioat_chan->dma_chan.device_node, &dma->channels);
>         ioat_dma->idx[idx] = ioat_chan;
> -       init_timer(&ioat_chan->timer);
> -       ioat_chan->timer.function = ioat_timer_event;
> -       ioat_chan->timer.data = data;
> +       setup_timer(&ioat_chan->timer, ioat_timer_event, data);
>         tasklet_init(&ioat_chan->cleanup_task, ioat_cleanup_event, data);
>  }
>
> --
> 2.9.3
>

Reviewed-by: Dan Williams <dan.j.williams@...el.com>