linux-kernel - Re: [PATCH] Staging: comedidev.h comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 9 Apr 2017 21:02:03 +0200
From:   Greg KH <greg@...ah.com>
To:     "Arthur Brainville (Ybalrid)" <ybalrid@...lrid.info>
Cc:     abbotti@....co.uk, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedidev.h comedi_lrange should be const struct

On Sun, Apr 09, 2017 at 04:28:12PM +0200, Arthur Brainville (Ybalrid) wrote:
> According to checkpatch.pl, comedi_lrange should be declared as `const
> struct` instead of `struct` in driver/staging/comedidev.h
> 
> Signed-off-by: Arthur Brainville (Ybalrid) <ybalrid@...lrid.info>
> ---
>  drivers/staging/comedi/comedidev.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 1bb9986f865e..82df090783b5 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -623,7 +623,7 @@ extern const struct comedi_lrange range_unknown;
>   * There may also be a flag that indicates the minimum and maximum are merely
>   * scale factors for an unknown, external reference.
>   */
> -struct comedi_lrange {
> +const struct comedi_lrange {
>  	int length;
>  	struct comedi_krange range[];
>  };

Huh?  Please explain how this change is correct.

greg k-h