linux-kernel - Re: [PATCH v5 19/23] drivers/fsi: Add GPIO based FSI master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <518e0abc-f1da-2ca0-fa44-6802e2b74c71@linux.vnet.ibm.com>
Date:   Sun, 9 Apr 2017 16:04:59 -0500
From:   Christopher Bostic <cbostic@...ux.vnet.ibm.com>
To:     Randy Dunlap <rdunlap@...radead.org>, robh+dt@...nel.org,
        mark.rutland@....com, linux@...linux.org.uk, rostedt@...dmis.org,
        mingo@...hat.com, gregkh@...uxfoundation.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc:     joel@....id.au, linux-kernel@...r.kernel.org, andrew@...id.au,
        alistair@...ple.id.au, benh@...nel.crashing.org,
        "Edward A . James" <eajames@...ibm.com>,
        Jeremy Kerr <jk@...abs.org>
Subject: Re: [PATCH v5 19/23] drivers/fsi: Add GPIO based FSI master



On 4/5/17 11:35 AM, Randy Dunlap wrote:
> On 04/04/17 19:06, Christopher Bostic wrote:
>> From: Chris Bostic <cbostic@...ux.vnet.ibm.com>
>>
>> Implement a FSI master using GPIO.  Will generate FSI protocol for
>> read and write commands to particular addresses.  Sends master command
>> and waits for and decodes a slave response.
>>
>> Includes changes from Edward A. James <eajames@...ibm.com> and Jeremy
>> Kerr <jk@...abs.org>.
>>
>> Signed-off-by: Edward A. James <eajames@...ibm.com>
>> Signed-off-by: Jeremy Kerr <jk@...abs.org>
>> Signed-off-by: Chris Bostic <cbostic@...ux.vnet.ibm.com>
>> Signed-off-by: Joel Stanley <joel@....id.au>
>> ---
>>   drivers/fsi/Kconfig           |  11 +
>>   drivers/fsi/Makefile          |   1 +
>>   drivers/fsi/fsi-master-gpio.c | 610 ++++++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 622 insertions(+)
>>   create mode 100644 drivers/fsi/fsi-master-gpio.c
>>
>> diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig
>> index 04c1a0e..9cf8345 100644
>> --- a/drivers/fsi/Kconfig
>> +++ b/drivers/fsi/Kconfig
>> @@ -9,4 +9,15 @@ config FSI
>>   	---help---
>>   	  FSI - the FRU Support Interface - is a simple bus for low-level
>>   	  access to POWER-based hardware.
>> +
>> +if FSI
>> +
>> +config FSI_MASTER_GPIO
>> +	tristate "GPIO-based FSI master"
>> +	depends on FSI && GPIOLIB
> depends on FSI is redundant since "if FSI" does the same thing.

Hi Randy,
Thanks for the feedback, will correct.

-Chris
>> +	---help---
>> +	This option enables a FSI master driver using GPIO lines.
>> +
>> +endif
>> +
>