linux-kernel - Re: [PATCH] phy: qcom-qmp: Add dependency on COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Apr 2017 12:35:59 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     Kishon Vijay Abraham I <kishon@...com>
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, sboyd@...eaurora.org,
        bjorn.andersson@...aro.org, srinivas.kandagatla@...aro.org,
        Fengguang Wu <fengguang.wu@...el.com>,
        linux-arm-msm-owner@...r.kernel.org
Subject: Re: [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK

On 2017-04-10 10:52, Kishon Vijay Abraham I wrote:
> On Friday 07 April 2017 01:37 AM, Vivek Gautam wrote:
>> The driver uses clock provider interface, and therefore
>> it fails to build when enabled for COMPILE_TEST, since
>> COMMON_CLK is not enabled at that time.
>> So, make PHY_QCOM_QMP depend on COMMON_CLK as well.
>> 
>> Cc: Fengguang Wu <fengguang.wu@...el.com>
>> Cc: Kishon Vijay Abraham I <kishon@...com>
>> Signed-off-by: Vivek Gautam <vivek.gautam@...eaurora.org>
>> ---
>> 
>> Hi Kishon,
>> 
>> This patch is fixing the build failures for architectures
>> such as, tile, and ia64, that don't enable COMMON_CLK by default.
>> You can either squash this into the qmp phy driver patch,
>> or put it as a separate patch with 'Fix' tag.
>> Let me know if you want me to add a 'fix' tag with a reference
>> to the commit ID.
> 
> I squashed it with your earlier patch and pushed.

Thanks Kishon.

Regards
Vivek

> 
> Thanks
> Kishon
> 
>> 
>> Regards
>> Vivek
>> 
>>  drivers/phy/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index bb8140355608..8550d3dc0b71 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -441,7 +441,7 @@ config PHY_STIH407_USB
>> 
>>  config PHY_QCOM_QMP
>>  	tristate "Qualcomm QMP PHY Driver"
>> -	depends on OF && (ARCH_QCOM || COMPILE_TEST)
>> +	depends on OF && COMMON_CLK && (ARCH_QCOM || COMPILE_TEST)
>>  	select GENERIC_PHY
>>  	help
>>  	  Enable this to support the QMP PHY transceiver that is used
>> 
> --
> To unsubscribe from this list: send the line "unsubscribe 
> linux-arm-msm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html