linux-kernel - Re: [PATCH v3] ia64: fix module loading for gcc-5.4+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170410225336.5856d652@sf>
Date:   Mon, 10 Apr 2017 22:53:36 +0100
From:   Sergei Trofimovich <slyfox@...too.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-ia64@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Fenghua Yu <fenghua.yu@...el.com>,
        "H. J. Lu" <hjl.tools@...il.com>, Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH v3] ia64: fix module loading for gcc-5.4+

On Mon, 10 Apr 2017 19:23:28 +0200
SF Markus Elfring <elfring@...rs.sourceforge.net> wrote:

> > -	if (slot(insn) != 2) {
> > +	if (slot(insn) != 1 && slot(insn) != 2) {  
> 
> +	int const s = slot(insn);
> +	if (s < 1 || s > 2) {
> 
> Do run time characteristics matter for such a condition check here?

It's done once at kernel module load time. My guess would be
"not critical at all".

slot() is a pure arithmetic static inline function. You can compare
assembly output before and after your change.

You can measure the difference yourself using 'ski' emulator.
That's for example how I debugged and tested the patch:
     http://trofi.github.io/posts/199-ia64-machine-emulation.html

-- 

  Sergei

Content of type "application/pgp-signature" skipped