linux-kernel - Re: [PATCH v3 7/9] arm,arm64,drivers: reduce scope of cap_parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170410083104.GC27538@e104818-lin.cambridge.arm.com>
Date:   Mon, 10 Apr 2017 09:31:05 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Juri Lelli <juri.lelli@....com>
Cc:     linux-kernel@...r.kernel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, lorenzo.pieralisi@....com,
        vincent.guittot@...aro.org, linux-pm@...r.kernel.org,
        peterz@...radead.org, broonie@...nel.org, will.deacon@....com,
        gregkh@...uxfoundation.org, dietmar.eggemann@....com,
        robh+dt@...nel.org, sudeep.holla@....com, linux@....linux.org.uk,
        morten.rasmussen@....com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 7/9] arm,arm64,drivers: reduce scope of
 cap_parsing_failed

On Mon, Mar 27, 2017 at 02:18:23PM +0100, Juri Lelli wrote:
> Reduce the scope of cap_parsing_failed (making it static in
> drivers/base/arch_topology.c) by slightly changing {arm,arm64} DT
> parsing code.
> 
> For arm checking for !cap_parsing_failed before calling normalize_
> cpu_capacity() is superfluous, as returning an error from parse_
> cpu_capacity() (above) means cap_from _dt is set to false.
> 
> For arm64 we can simply check if raw_capacity points to something,
> which is not if capacity parsing has failed.
> 
> Suggested-by: Morten Rasmussen <morten.rasmussen@....com>
> Signed-off-by: Juri Lelli <juri.lelli@....com>
> ---
>  arch/arm/kernel/topology.c   | 3 +--
>  arch/arm64/kernel/topology.c | 5 +----
>  drivers/base/arch_topology.c | 4 ++--
>  3 files changed, 4 insertions(+), 8 deletions(-)

Acked-by: Catalin Marinas <catalin.marinas@....com>