linux-kernel - Re: [PATCHv2] x86/intel_rdt: Add cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1704101110460.2906@nanos>
Date:   Mon, 10 Apr 2017 11:14:36 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Fenghua Yu <fenghua.yu@...el.com>
cc:     Jiri Olsa <jolsa@...hat.com>, Jiri Olsa <jolsa@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Mike Galbraith <efault@....de>, Shaohua Li <shli@...com>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCHv2] x86/intel_rdt: Add cpus_list rdtgroup file

On Sun, 9 Apr 2017, Fenghua Yu wrote:
> >  	rdtgrp = rdtgroup_kn_lock_live(of->kn);
> >  
> > -	if (rdtgrp)
> > -		seq_printf(s, "%*pb\n", cpumask_pr_args(&rdtgrp->cpu_mask));
> > -	else
> > +	if (rdtgrp) {
> > +		seq_printf(s, is_list(of) ? "%*pbl\n" : "%*pb\n",
> > +			   cpumask_pr_args(&rdtgrp->cpu_mask));
> > +	} else
> 
> Unbalanced braces around if-else. You can remove the { and } after if.

Wrong. I've explained that a gazillion of times already.

http://lkml.kernel.org/r/alpine.DEB.2.20.1701171956290.3645@nanos

So yes, the else path wants braces.

Thanks,

	tglx