linux-kernel - [PATCH 09/11] f2fs: Remove __GFP_NOFAIL flag from call to mempool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <8737dhxaym.fsf@notabene.neil.brown.name>
Date:   Mon, 10 Apr 2017 12:17:37 +1000
From:   NeilBrown <neilb@...e.com>
To:     Jaegeuk Kim <jaegeuk@...nel.org>, Chao Yu <yuchao0@...wei.com>
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: [PATCH 09/11] f2fs: Remove __GFP_NOFAIL flag from call to mempool_alloc()


Passing __GFP_NOFAIL to mempool_alloc() is strange
because it bypasses the pool functionality provided
by the mempool.  mempool_alloc() will not fail
even without the NOFAIL flag.

So remove the flag and allow the pool to be used properly.

Signed-off-by: NeilBrown <neilb@...e.com>
---
 fs/f2fs/data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 1602b4bccae6..7e31751ec708 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -204,7 +204,7 @@ static inline void __submit_bio(struct f2fs_sb_info *sbi,
 		for (; start < F2FS_IO_SIZE(sbi); start++) {
 			struct page *page =
 				mempool_alloc(sbi->write_io_dummy,
-					GFP_NOIO | __GFP_ZERO | __GFP_NOFAIL);
+					GFP_NOIO | __GFP_ZERO);
 			f2fs_bug_on(sbi, !page);
 
 			SetPagePrivate(page);
-- 
2.12.2


Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)