linux-kernel - Re: [PATCH 2/2] drivers: char: Replace fail_printk with fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170410134332.GB21327@kroah.com>
Date:   Mon, 10 Apr 2017 15:43:32 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Varsha Rao <rvarsha016@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] drivers: char: Replace fail_printk with fail_print.

On Mon, Apr 10, 2017 at 12:29:56PM +0530, Varsha Rao wrote:
> As printk is no longer used here, rename the label fail_printk as
> fail_print.
> 
> Signed-off-by: Varsha Rao <rvarsha016@...il.com>
> ---
>  drivers/char/misc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
> index 5786281..0fed477 100644
> --- a/drivers/char/misc.c
> +++ b/drivers/char/misc.c
> @@ -293,11 +293,11 @@ static int __init misc_init(void)
>  
>  	err = -EIO;
>  	if (register_chrdev(MISC_MAJOR, "misc", &misc_fops))
> -		goto fail_printk;
> +		goto fail_print;
>  	misc_class->devnode = misc_devnode;
>  	return 0;
>  
> -fail_printk:
> +fail_print:
>  	pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);
>  	class_destroy(misc_class);

That's really a pointless change, don't you think?

sorry,

greg k-h