linux-kernel - Re: [PATCH] phy: qcom-qmp: select COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bcb76eb8-586c-0ff8-4cae-ce4d75472ed8@ti.com>
Date:   Mon, 10 Apr 2017 10:31:57 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Jérémy Lefaure <jeremy.lefaure@....epita.fr>,
        Vivek Gautam <vivek.gautam@...eaurora.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: qcom-qmp: select COMMON_CLK

Hi,

On Monday 10 April 2017 02:45 AM, Jérémy Lefaure wrote:
> It is impossible to build Qualcom QMP phy driver without COMMON_CLK
> enabled:
>   CC      drivers/phy/phy-qcom-qmp.o
> drivers/phy/phy-qcom-qmp.c: In function ‘phy_pipe_clk_register’:
> drivers/phy/phy-qcom-qmp.c:932:9: error: variable ‘init’ has initializer
> but incomplete type
>   struct clk_init_data init = { };
>          ^~~~~~~~~~~~~
> drivers/phy/phy-qcom-qmp.c:932:23: error: storage size of ‘init’ isn’t
> known
>   struct clk_init_data init = { };
>                        ^~~~
> ...
> 
> Selecting COMMON_CLK when PHY_QCOM_QMP is enabled fix this issue.
> 
> Fixes: 93a8c0c7b1ad ("phy: qcom-qmp: new qmp phy driver for qcom-chipsets")
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@....epita.fr>

Vivek has already sent a patch for this. I have picked that.

Thanks
Kishon
> ---
>  drivers/phy/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index c120071fd2c8..e881eb2ef305 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -443,6 +443,7 @@ config PHY_QCOM_QMP
>  	tristate "Qualcomm QMP PHY Driver"
>  	depends on OF && (ARCH_QCOM || COMPILE_TEST)
>  	select GENERIC_PHY
> +	select COMMON_CLK
>  	help
>  	  Enable this to support the QMP PHY transceiver that is used
>  	  with controllers such as PCIe, UFS, and USB on Qualcomm chips.
>