linux-kernel - Re: [PATCH 2/3] x86/numa_emulation: assign physnode_mask directly from numa_nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1704101722540.116868@chino.kir.corp.google.com>
Date:   Mon, 10 Apr 2017 17:26:03 -0700 (PDT)
From:   David Rientjes <rientjes@...gle.com>
To:     Wei Yang <richard.weiyang@...il.com>
cc:     kirill@...temov.name, bp@...en8.de, tglx@...utronix.de,
        mingo@...hat.com, hpa@...or.com, tj@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] x86/numa_emulation: assign physnode_mask directly
 from numa_nodes_parsed

On Tue, 11 Apr 2017, Wei Yang wrote:

> According to current code path, numa_nodes_parsed is already setup when
> numa_emucation() is called.
> 
>     x86_numa_init()
>         numa_init()
> 	    init_func()
> 
> 	    numa_emulation()
> 
>             numa_register_memblks()
>

s/numa_emucation/numa_emulation/, but I think everything above should just 
be reworded to say the following since it establishes the dependency:

numa_init() has already called init_func(), which is responsible for 
setting numa_nodes_parsed, so use this nodemask instead of re-finding it 
when calling numa_emulation().

> This means we can get the physnode_mask directly from numa_nodes_parsed. At
> the same time, this patch correct the comment of these two functions.
> 
> Signed-off-by: Wei Yang <richard.weiyang@...il.com>

Acked-by: David Rientjes <rientjes@...gle.com>