linux-kernel - Re: [tip:x86/mm] x86/asm: Remove __VIRTUAL_MASK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170411071242.GA23772@gmail.com>
Date:   Tue, 11 Apr 2017 09:12:42 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:     Denys Vlasenko <dvlasenk@...hat.com>, brgerst@...il.com,
        torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
        luto@...capital.net, linux-kernel@...r.kernel.org,
        jpoimboe@...hat.com, luto@...nel.org, peterz@...radead.org,
        bp@...en8.de, hpa@...or.com, dave.hansen@...el.com,
        tglx@...utronix.de, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/mm] x86/asm: Remove __VIRTUAL_MASK_SHIFT==47 assert


* Kirill A. Shutemov <kirill.shutemov@...ux.intel.com> wrote:

> On Wed, Apr 05, 2017 at 01:50:27PM +0200, Denys Vlasenko wrote:
> > Er.... "Change top bits ... ((47 or 56 [bits] depending on paging mode)"?
> > I know that's wrong and that's not what you meant to say,
> > but it can be read this way too. "47th" instead of "47"
> > would eliminate this reading, but you removed "th".
> > 
> > Spell it out to eliminate any chance of confusion:
> > 
> > 	Change top bits to match most significant bit (47th or 56th bit
> > 	depending on paging mode) in the address.
> > 
> 
> ---------------------8<-----------------------
> 
> From 5dec28ba49387ff444e447213b553506e253616d Mon Sep 17 00:00:00 2001
> From: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
> Date: Wed, 5 Apr 2017 14:06:15 +0300
> Subject: [PATCH] x86/asm: Fix comment in return_from_SYSCALL_64
> 
> On x86-64 __VIRTUAL_MASK_SHIFT depends on paging mode now.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

Could you please integrate this into your series to make sure I apply all the 
intended+latest bits?

Thanks,

	Ingo