linux-kernel - Re: [PATCH v2] IIO: bmp280-core.c: fix error in humidity calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZMudg8UP-J_JM38v7CDLD4VwbFEgJesZ+MXc9O=+Ey2g@mail.gmail.com>
Date:   Tue, 11 Apr 2017 09:45:56 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andreas Klinger <ak@...klinger.de>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Matt Ranostay <matt.ranostay@...sulko.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        Vlad Dogaru <ddvlad@...il.com>,
        Akinobu Mita <akinobu.mita@...il.com>,
        Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
        Aniroop Mathur <a.mathur@...sung.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] IIO: bmp280-core.c: fix error in humidity calculation

On Mon, Apr 10, 2017 at 7:00 PM, Andreas Klinger <ak@...klinger.de> wrote:

> While calculating the compensation of the humidity there are negative values
> interpreted as unsigned because of unsigned variables used.  These values as
> well as the constants need to be casted to signed as indicated by the
> documentation of the sensor.
>
> Changes in v2:
> - cast also constants to signed; otherwise calculation is not correct
>
> I removed the Acked-By of Linus Walleij because of another change in the
> calculation. Don't know how it should be treated.

Acked-by: Linus Walleij <linus.walleij@...aro.org>

You guys do an awesome job at maintaining the sensor code, thanks.

Yours,
Linus Walleij