linux-kernel - [PATCH] Revert "HID: rmi: Handle all Synaptics touchpads using hid-rmi"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1704111122410.28004@cbobk.fhfr.pm>
Date:   Tue, 11 Apr 2017 11:24:37 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Gabriele Mazzotta <gabriele.mzt@...il.com>, aduggan@...aptics.com,
        benjamin.tissoires@...hat.com,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Peter Hutterer <peter.hutterer@...-t.net>,
        Cameron Gutman <aicommander@...il.com>,
        Thorsten Leemhuis <linux@...mhuis.info>,
        Nick Dyer <nick@...anahar.org>,
        Christopher Heiny <cheiny@...aptics.com>,
        Jason Ekstrand <jason@...kstrand.net>
cc:     linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: [PATCH] Revert "HID: rmi: Handle all Synaptics touchpads using
 hid-rmi"

From: Jiri Kosina <jkosina@...e.cz>

This reverts commit 279967a65b320d174a507498aea7d44db3fee7f4.

Multiple regressions [1] [2] [3] have been reported. The hid-rmi
support would have to fixed and redone in 4.11+.

[1] http://lkml.kernel.org/r/b79b88c8-770a-13f6-5668-c3a94254e5e0@gmail.com
[2] http://lkml.kernel.org/r/375e67b5-2cb8-3491-1d71-d8650d6e9451@gmail.com
[3] https://bugzilla.kernel.org/show_bug.cgi?id=195287

Reported-by: Cameron Gutman <aicommander@...il.com>
Reported-by: Gabriele Mazzotta <gabriele.mzt@...il.com>
Reported-by: Lorenzo J. Lucchini <ljlbox@...cali.it>
Reported-by: Thorsten Leemhuis <linux@...mhuis.info>
Signed-off-by: Jiri Kosina <jkosina@...e.cz>
---
 drivers/hid/hid-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 86bbd8a1fd4a..d162f0dc76e3 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -819,8 +819,7 @@ static int hid_scan_report(struct hid_device *hid)
 		hid->group = HID_GROUP_WACOM;
 		break;
 	case USB_VENDOR_ID_SYNAPTICS:
-		if (hid->group == HID_GROUP_GENERIC ||
-		    hid->group == HID_GROUP_MULTITOUCH_WIN_8)
+		if (hid->group == HID_GROUP_GENERIC)
 			if ((parser->scan_flags & HID_SCAN_FLAG_VENDOR_SPECIFIC)
 			    && (parser->scan_flags & HID_SCAN_FLAG_GD_POINTER))
 				/*
-- 
Jiri Kosina
SUSE Labs