linux-kernel - Re: [PATCH] mtd: nand: omap2: Fix partition creation via cmdline mtdparts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170411133909.3b25a054@bbrezillon>
Date:   Tue, 11 Apr 2017 13:39:09 +0200
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Roger Quadros <rogerq@...com>
Cc:     <richard@....at>, <aford173@...il.com>, <enrico.leto@...mens.com>,
        <linux-mtd@...ts.infradead.org>, <linux-omap@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, "# 4 . 7+" <stable@...r.kernel.org>
Subject: Re: [PATCH] mtd: nand: omap2: Fix partition creation via cmdline
 mtdparts

On Thu, 30 Mar 2017 10:37:50 +0300
Roger Quadros <rogerq@...com> wrote:

> commit c9711ec5250b ("mtd: nand: omap: Clean up device tree support")
> caused the parent device name to be changed from "omap2-nand.0"
> to "<base address>.nand"  (e.g. 30000000.nand on omap3 platforms).
> This caused mtd->name to be changed as well. This breaks partition
> creation via mtdparts passed by u-boot as it uses "omap2-nand.0"
> for the mtd-id.
> 
> Fix this by explicitly setting the mtd->name to "omap2-nand.<CS number>"
> if it isn't already set by nand_set_flash_node(). CS number is the
> NAND controller instance ID.
> 

Applied.

Thanks,

Boris

> Fixes: c9711ec5250b ("mtd: nand: omap: Clean up device tree support")
> Cc: <stable@...r.kernel.org> # 4.7+
> Reported-by: Leto Enrico <enrico.leto@...mens.com>
> Reported-by: Adam Ford <aford173@...il.com>
> Suggested-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> Tested-by: Adam Ford <aford173@...il.com>
> Signed-off-by: Roger Quadros <rogerq@...com>
> ---
>  drivers/mtd/nand/omap2.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 2a52101..084934a 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1856,6 +1856,15 @@ static int omap_nand_probe(struct platform_device *pdev)
>  	nand_chip->ecc.priv	= NULL;
>  	nand_set_flash_node(nand_chip, dev->of_node);
>  
> +	if (!mtd->name) {
> +		mtd->name = devm_kasprintf(&pdev->dev, GFP_KERNEL,
> +					   "omap2-nand.%d", info->gpmc_cs);
> +		if (!mtd->name) {
> +			dev_err(&pdev->dev, "Failed to set MTD name\n");
> +			return -ENOMEM;
> +		}
> +	}
> +
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	nand_chip->IO_ADDR_R = devm_ioremap_resource(&pdev->dev, res);
>  	if (IS_ERR(nand_chip->IO_ADDR_R))