linux-kernel - Re: [PATCH RFC 2/4] coresight: tmc: set read pointer before dump RAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170411134645.GB8996@leoy-linaro>
Date:   Tue, 11 Apr 2017 21:46:45 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Chunyan Zhang <zhang.lyra@...il.com>
Cc:     Mathieu Poirier <mathieu.poirier@...aro.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mike Leach <mike.leach@...aro.org>,
        Suzuki K Poulose <suzuki.poulose@....com>
Subject: Re: [PATCH RFC 2/4] coresight: tmc: set read pointer before dump RAM

On Tue, Apr 11, 2017 at 07:25:30PM +0800, Chunyan Zhang wrote:
> On 11 April 2017 at 17:10, Leo Yan <leo.yan@...aro.org> wrote:
> > When dump RAM, we need set read pointer so can make sure every time read
> > the consistent content. If the RAM is full by checking status register
> > (STS), so set the read pointer to same value with write pointer,
> > otherwise set read point to 0 so can read from the start of RAM.
> >
> > Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
> > Cc: Mike Leach <mike.leach@...aro.org>
> > Cc: Suzuki K Poulose <suzuki.poulose@....com>
> > Signed-off-by: Leo Yan <leo.yan@...aro.org>
> > ---
> >  drivers/hwtracing/coresight/coresight-tmc-etf.c | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c
> > index 6150dac..43cfeaa 100644
> > --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c
> > +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c
> > @@ -43,10 +43,28 @@ static void tmc_etb_enable_hw(struct tmc_drvdata *drvdata)
> >
> >  static void tmc_etb_dump_hw(struct tmc_drvdata *drvdata)
> >  {
> > +       u32 write_ptr, status;
> >         char *bufp;
> >         u32 read_data;
> >         int i;
> >
> > +       write_ptr = readl_relaxed(drvdata->base + TMC_RWP);
> 
> Since 'write_ptr' is only used in the below 'if' branch, I would
> suggest to move this statement into that.

Thanks, Chunyan. Agree, will fix.

> > +
> > +       /*
> > +        * Get a hold of the status register and see if a wrap around
> > +        * has occurred.  If so adjust things accordingly.
> > +        */
> > +       status = readl_relaxed(drvdata->base + TMC_STS);
> > +       if (status & TMC_STS_FULL)
> > +               /* Tell the HW the reading start point */
> > +               writel_relaxed(write_ptr, drvdata->base + TMC_RRP);
> > +       else
> > +               /*
> > +                * In case this is not first time to read ETB RAM,
> > +                * always write 0 for reading pointer.
> > +                */
> > +               writel_relaxed(0x0, drvdata->base + TMC_RRP);
> > +
> >         bufp = drvdata->buf;
> >         drvdata->len = 0;
> >         while (1) {
> > --
> > 2.7.4
> >