linux-kernel - Re: [PATCH net-next] net: ethernet: mediatek: enhance TX path with recycling more SKBs in one poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170411.104924.1724009300333538121.davem@davemloft.net>
Date:   Tue, 11 Apr 2017 10:49:24 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     sean.wang@...iatek.com
Cc:     john@...ozen.org, nbd@...nwrt.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        keyhaede@...il.com
Subject: Re: [PATCH net-next] net: ethernet: mediatek: enhance TX path with
 recycling more SKBs in one poll

From: <sean.wang@...iatek.com>
Date: Tue, 11 Apr 2017 16:34:27 +0800

> From: Sean Wang <sean.wang@...iatek.com>
> 
> The patch adds the enhancement for recycling more TX completed SKBs in
> one NAPI polling handler if NAPI budgets are still available and hardware
> raises status bit shown for certain SKBs are aready done.
> 
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>

You should always, unconditionally, process all TX reclaim events
every NAPI poll, regardless of how much budget is left.

TX reclaim work is not counted against the NAPI budget, only RX work
should be.