linux-kernel - Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33903dfc-9ee3-d6cb-0868-c13c84941e08@osg.samsung.com>
Date:   Tue, 11 Apr 2017 09:58:54 -0600
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Darren Hart <dvhart@...radead.org>,
        Michael Ellerman <mpe@...erman.id.au>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-kselftest@...r.kernel.org, bamvor.zhangjian@...wei.com,
        stable@...r.kernel.org, Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable

On 03/27/2017 08:23 PM, Darren Hart wrote:
> On Tue, Mar 28, 2017 at 11:19:25AM +1100, Michael Ellerman wrote:
>> Darren Hart <dvhart@...radead.org> writes:
>>
>>> The use of $$OUTPUT in the target shell commands resulted in an empty
>>> string followed by an absolute path for which mkdir failed:
>>>
>>> $ make -C tools/testing/selftests/futex
>>> make: Entering directory '/home/dvhart/source/linux/linux-pdx86/tools/testing/selftests/futex'
>>> Makefile:36: warning: overriding recipe for target 'clean'
>>> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
>>> for DIR in functional; do		\
>>> 	BUILD_TARGET=$OUTPUT/$DIR;	\
>>> 	mkdir $BUILD_TARGET  -p;	\
>>> 	make OUTPUT=$BUILD_TARGET -C $DIR all;\
>>> done
>>> mkdir: cannot create directory ‘/functional’: Permission denied
>>>
>>> Replace $$OUTPUT with $(OUTPUT) when referring to the Makefile OUTPUT
>>> variable. The above make command now completes successfully.
>>>
>>> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
>>> Signed-off-by: Darren Hart (VMware) <dvhart@...radead.org>
>>> Cc: linux-kselftest@...r.kernel.org
>>> Cc: bamvor.zhangjian@...wei.com
>>> Cc: Shuah Khan <shuah@...nel.org>
>>> Cc: <stable@...r.kernel.org> # 4.10.x-
>>
>> The OUTPUT support only went into v4.11-rc1, so I don't see why you need
>> a stable tag?
> 
> Git spelunking failure on my part, you are correct. Please disregard the stable
> tag.
> 
>>
>> Change looks good though.
>>
> 
> Thank you for the review.
> 

Thanks for fixing this.

Applied to linux-kselftest next after removing the stable tag.

-- Shuah