linux-kernel - Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8737df0vzs.fsf@eliezer.anholt.net>
Date:   Tue, 11 Apr 2017 09:06:31 -0700
From:   Eric Anholt <eric@...olt.net>
To:     Russell King - ARM Linux <linux@...linux.org.uk>
Cc:     dri-devel@...ts.freedesktop.org, tom.cooksey@....com,
        linus.walleij@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

Russell King - ARM Linux <linux@...linux.org.uk> writes:

> On Mon, Apr 10, 2017 at 06:18:01PM -0700, Eric Anholt wrote:
>> v5: Move register definitions inside the driver directory, fix build
>>     in COMPILE_TEST and !AMBA mode.
>
> Why is it necessary to move the register definitions there, when
> they're already available in linux/amba/clcd.h and are required
> for the FB driver?
>
> It is absurd to have driver specific register definitions.

Because after v2, v3, and v4, I still didn't have an ack on the patch to
move the register definitions from linux/amba/clcd.h to
linux/amba/clcd-reg.h.  If you'd like to go back and ack that, I'd reuse
them.

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)