linux-kernel - Re: [PATCH] net: phy: micrel: KSZ9031: fix crash when statistic requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a397cb88-4fd9-b34d-ab96-54604be7e6df@ti.com>
Date:   Tue, 11 Apr 2017 12:17:16 -0500
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        Sekhar Nori <nsekhar@...com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: phy: micrel: KSZ9031: fix crash when statistic
 requested



On 04/11/2017 11:36 AM, Andrew Lunn wrote:
>> I've considered all this option, honestly, but I do not know if this
>> phys (issue should affect KSZ886X, KSZ8873MLL, KSZ9031, KSZ9021, KSZ8061, KS8737)
>> support fetching statistics or not and was hoping to get feedback from community.
>
> Hi Grygorii
>
> Microchip are one of the good guys. All there datesheets are open. So
> you should be able to check this.


Below is what i've found
			0xa 0x15 action
KS8737			-   +    remove stats? - reg 10(0xa) reserved
KSZ8061MNX/MNG		-   +	 remove stats? - reg 10(0xa) reserved
KSZ9021GN		+   +    add .probe()
KSZ9031 		+   +    add .probe()
KSZ8873MLL/FLL/RLL      -   -    remove stats
KSZ886X/KSZ8862		-   -    remove stats

The kszphy_probe() can be reused as .probe() callback as it seems
not phy specific.


-- 
regards,
-grygorii