linux-kernel - Re: [PATCH 2/2] ASoC: hisilicon: Minor fixups to hi6210 i2s audio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALAqxLW+EOk3jpkzX7g6u3r38rLQAZoKbK8X7YAwRovWoxYyKA@mail.gmail.com>
Date:   Tue, 11 Apr 2017 12:04:57 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Zhangfei Gao <zhangfei.gao@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Wei Xu <xuwei5@...ilicon.com>,
        Rob Herring <robh+dt@...nel.org>,
        Andy Green <andy@...mcat.com>,
        Dave Long <dave.long@...aro.org>,
        Guodong Xu <guodong.xu@...aro.org>
Subject: Re: [PATCH 2/2] ASoC: hisilicon: Minor fixups to hi6210 i2s audio driver

On Tue, Apr 11, 2017 at 11:34 AM, Mark Brown <broonie@...nel.org> wrote:
> On Mon, Apr 10, 2017 at 12:35:12PM -0700, John Stultz wrote:
>
>> This patch adds a few extra error returns in cases that
>> shouldn't happen, some style nits adding breaks to final
>> default cases in switch statements, and tweaks to use
>> devm_ variant of snd_soc_register_component.
>
> Please don't make multiple unrelated changes in a single patch, it's bad
> practice which can slow down the bits of the patch which are OK and
> makes it harder to review if the changes match up with the changelog.

Apologies, I'll split it up and resend.

>>  static int hi6210_i2s_remove(struct platform_device *pdev)
>>  {
>>         snd_soc_unregister_component(&pdev->dev);
>
> Since you converted to devm_ this is now going to be a double free.

Ah. So it looks like can yank the whole remove implementation.

thanks
-john