linux-kernel - Re: [PATCH 5/6] regulator: anatop-regulator: make regulator-name using optionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170411203817.5f32em4v5xiwzchl@sirena.org.uk>
Date:   Tue, 11 Apr 2017 21:38:18 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Dong Aisheng <aisheng.dong@....com>
Cc:     linux-kernel@...r.kernel.org, shawnguo@...nel.org,
        linux-arm-kernel@...ts.infradead.org, kernel@...gutronix.de,
        lgirdwood@...il.com, yibin.gong@....com
Subject: Re: [PATCH 5/6] regulator: anatop-regulator: make regulator-name
 using optionally

On Wed, Apr 12, 2017 at 09:58:46AM +0800, Dong Aisheng wrote:
> rdesc->name/regulator-name is optional according to standard regulator
> binding doc. Use it conditionally to avoid a kernel NULL point crash.

It is optional in the standard binding because it is used to override
the name statically provided in the driver for the device.  Since the
anatop regulator is completely dynamic (there's no static list of
regulators in the device) it's mandatory for anatop regulators - you
should improve the error handling instead to detect a missing name.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)