linux-kernel - Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <edc488b1-8ea1-fc69-0700-68ffaf8f6742@gmail.com>
Date:   Tue, 11 Apr 2017 13:59:08 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

On 04/11/2017 01:52 PM, Vivien Didelot wrote:
> This patch moves as is the legacy DSA code from dsa.c to legacy.c,
> except the few shared symbols which remain in dsa.c.
> 
> Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled,
> which is true by default.
> 
> DSA drivers without legacy support don't need the probe function as well
> as driver registration helpers anymore, so remove their definitions if
> CONFIG_NET_DSA_LEGACY is disabled.
> 
> NET_DSA_MV88E6060 and NET_DSA_BCM_SF2 now depend on the legacy support.

BCM_SF2 is not dependent on legacy support since it got converted to the
new API in the past few months.

You may want to generate your patch with git format-patch -M to help
detect renames/code movements.

Thanks for doing this!
-- 
Florian