linux-kernel - Re: [PATCH 4/4] f2fs: avoid frequent checkpoint during f2fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170411221359.GA4073@jaegeuk.local>
Date:   Tue, 11 Apr 2017 15:13:59 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Chao Yu <yuchao0@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [PATCH 4/4] f2fs: avoid frequent checkpoint during f2fs_gc

On 04/11, Chao Yu wrote:
> On 2017/4/11 8:13, Jaegeuk Kim wrote:
> > Now we're doing SSR aggressively more than ever before, so once we reach to
> > the reserved_segment, f2fs_balance_fs will call f2fs_gc, which triggers
> > checkpoint everytime. We actually must avoid that.
> > 
> > Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> > ---
> >  fs/f2fs/gc.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> > index e2f9b2b12b74..4a720f3394d9 100644
> > --- a/fs/f2fs/gc.c
> > +++ b/fs/f2fs/gc.c
> > @@ -966,7 +966,11 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, bool background)
> >  		 * threshold, we can make them free by checkpoint. Then, we
> >  		 * secure free segments which doesn't need fggc any more.
> >  		 */
> > -		ret = write_checkpoint(sbi, &cpc);
> > +		if (prefree_segments(sbi)) {
> > +			ret = write_checkpoint(sbi, &cpc);
> > +			if (ret)
> > +				goto stop;
> > +		}
> >  		if (ret)
> >  			goto stop;
> 
> We don't need redundant check here?

Yup, will remove this. ;)

> 
> Otherwise, this patchset looks good to me, anyway please add:
> 
> Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,

> 
> Thanks,
> 
> >  		if (has_not_enough_free_secs(sbi, 0, 0))
> >