linux-kernel - Re: [PATCH v2] input: misc: yealink: define packet offset _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Apr 2017 20:39:56 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Martin Kepplinger <martin.kepplinger@...zinger.com>
Cc:     Henk.Vergonet@...il.com, usbb2k-api-dev@...gnu.org,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] input: misc: yealink: define packet offset __be16
 instead of u16

On Mon, Apr 10, 2017 at 05:00:22PM +0200, Martin Kepplinger wrote:
> sparse says
> 
>  warning: incorrect type in assignment (different base types)
>     expected unsigned short [unsigned] [usertype] offset
>     got restricted __be16 [usertype] <noident>
> 
> for every usage of cpu_to_be16 in yealink.c. Defining it __be16 in the
> first place shouldn't hurt.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@...zinger.com>
> Signed-off-by: Henk.Vergonet@...il.com

Applied, thank you.

> ---
> revision history
> ----------------
> v2: add privately received Signed-off-by
> 
> 
>  drivers/input/misc/yealink.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/yealink.h b/drivers/input/misc/yealink.h
> index 1e0f523..934c247 100644
> --- a/drivers/input/misc/yealink.h
> +++ b/drivers/input/misc/yealink.h
> @@ -28,7 +28,7 @@
>  struct yld_ctl_packet {
>  	u8	cmd;		/* command code, see below */
>  	u8	size;		/* 1-11, size of used data bytes. */
> -	u16	offset;		/* internal packet offset */
> +	__be16	offset;		/* internal packet offset */
>  	u8	data[11];
>  	s8	sum;		/* negative sum of 15 preceding bytes */
>  } __attribute__ ((packed));
> -- 
> 2.1.4
> 

-- 
Dmitry