linux-kernel - Re: iov_iter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170411235158.GK29622@ZenIV.linux.org.uk>
Date:   Wed, 12 Apr 2017 00:51:58 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Dave Jones <davej@...emonkey.org.uk>,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: iov_iter_pipe warning.

On Tue, Apr 11, 2017 at 07:45:58PM -0400, Dave Jones wrote:
>  > 	if (file->f_op->splice_write == generic_splice_sendpage) {
>  > 		struct socket *sock = file->private_data;
>  > 		printk(KERN_ERR "socket [%d, %p]\n", sock->type, sock->ops);
>  > 	}
>  > 	printk(KERN_ERR "in->f_op = %p\n", in->f_op);
> 
> Ugh, this explodes with a million errors when I try to compile it. 
> It misses socket definition, and include <linux/net.h> causes another
> cascade of errors about linkage.h and nonsense.

Ignore the socket part - you've already triggered it with NFS file as
destination, so this is not particularly interesting.  I would still like
to see in->f_op and even more - the checks in default_file_splice_read().