linux-kernel - Re: [PATCH 03/17] thermal: cpu_cooling: Replace cpufreq_device with cpufreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170412061652.GA5910@vireshk-i7>
Date:   Wed, 12 Apr 2017 11:46:52 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Eduardo Valentin <edubezval@...il.com>
Cc:     Rafael Wysocki <rjw@...ysocki.net>,
        Javi Merino <javi.merino@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Amit Daniel Kachhap <amit.kachhap@...il.com>,
        linaro-kernel@...ts.linaro.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH 03/17] thermal: cpu_cooling: Replace cpufreq_device with
 cpufreq_dev

On 11-04-17, 10:33, Eduardo Valentin wrote:
> On Thu, Mar 16, 2017 at 10:59:38AM +0530, Viresh Kumar wrote:
> > Objects of "struct cpufreq_cooling_device" are named a bit
> > inconsistently. Lets use cpufreq_dev everywhere.
> > 
> 
> Naming is always a matter of taste.. but I frankly cannot see how this
> patch improves anything here. cpufreq_dev is still misleading.

I wasn't trying to get to a better name, but rather be consistent.

> Here other options:
>  cpufreq_cooling_dev: not misleading but, may a bit too long..
>  cpufreq_cdev: better, but still, not a char dev

I will go for the second one.

-- 
viresh