linux-kernel - Re: [PATCH RESEND] scsi: return correct blkprep status code in case scsi_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170412065413.GA4988@linux-x5ow.site>
Date:   Wed, 12 Apr 2017 08:54:13 +0200
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Bart Van Assche <Bart.VanAssche@...disk.com>
Cc:     "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "hch@....de" <hch@....de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hare@...e.de" <hare@...e.de>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH RESEND] scsi: return correct blkprep status code in case
 scsi_init_io() fails.

On Tue, Apr 11, 2017 at 06:43:22PM +0000, Bart Van Assche wrote:
> On Tue, 2017-04-11 at 09:46 +0200, Johannes Thumshirn wrote:
> > When instrumenting the SCSI layer to run into the
> > !blk_rq_nr_phys_segments(rq) case the following  warning emitted from the
> > block layer:
> > 
> > blk_peek_request: bad return=-22
> > 
> > This happens because since commit fd3fc0b4d730 ('scsi: don't BUG_ON()
> > empty DMA transfers') we return the wrong error value from iscsi_prep_fn()
>                                                              ^^^^^^^^^^^^^^^
> There is no iscsi_prep_fn() in the kernel tree. Did you perhaps mean
> scsi_prep_fn()?

*doh* Yup, you're right.

> 
> > back to the block layer.
> > 
> > Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>
> > Fixes: fd3fc0b4d730 scsi: don't BUG_ON() empty DMA transfers
> > Reviewed-by: Christoph Hellwig <hch@....de>
> 
> Commit fd3fc0b4d730 has a "Cc: stable" tag. I assume that that means that
> this patch also needs that tag?

Probably yes. I'll include both "fixes" in my resend.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850