linux-kernel - Re: [PATCH] irqchip/irq-imx-gpcv2: Clear OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a6da3596-c6a1-628f-d4f1-47fd20b53ea4@arm.com>
Date:   Wed, 12 Apr 2017 09:19:38 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     yurovsky@...il.com, Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>
Subject: Re: [PATCH] irqchip/irq-imx-gpcv2: Clear OF_POPULATED flag

On 11/04/17 17:48, Andrey Smirnov wrote:
> Clear OF_POPULATED flag, so that GPC power domain driver[1] can be
> bound to "gpc" node as well.
> 
> [1] https://lkml.org/lkml/2017/3/28/835
> 
> Cc: yurovsky@...il.com
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Jason Cooper <jason@...edaemon.net>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> ---
> 
> Marc:
> 
> You've expressed you disagreement (in [thread]) for adding generic
> infrastructure to perform this kind of trickery because of its
> DT-specific nature. Any chance this, more contained version of it, is
> acceptable?
> 
> Thanks,
> Andrey Smirnov
> 
> [thread] https://lkml.org/lkml/2017/1/30/241
> 
>  drivers/irqchip/irq-imx-gpcv2.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
> index 15af9a9..e13236f 100644
> --- a/drivers/irqchip/irq-imx-gpcv2.c
> +++ b/drivers/irqchip/irq-imx-gpcv2.c
> @@ -266,6 +266,11 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
>  	imx_gpcv2_instance = cd;
>  	register_syscore_ops(&imx_gpcv2_syscore_ops);
>  
> +	/*
> +	 * Clear the OF_POPULATED flag set in of_irq_init so that
> +	 * later the GPC power domain driver will not be skipped.
> +	 */
> +	of_node_clear_flag(node, OF_POPULATED);
>  	return 0;
>  }

Fair enough, I'll pick that one. It is still pretty horrible, but given
that this is an issue with the kernel at large, that's probably the best
we can do.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...