linux-kernel - Re: [PATCH 2/3] f2fs: shrink blk plug region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01ed1c10-f698-8e8c-2f76-f7c61265a844@huawei.com>
Date:   Wed, 12 Apr 2017 16:33:37 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     <jaegeuk@...nel.org>
CC:     <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>, <chao@...nel.org>
Subject: Re: [PATCH 2/3] f2fs: shrink blk plug region

Hi Jaegeuk,

Just reminding, miss merging this patch? :)

Thanks,

On 2017/3/27 18:14, Chao Yu wrote:
> Don't use blk plug covering area where there won't be any IOs being issued.
> 
> Signed-off-by: Chao Yu <yuchao0@...wei.com>
> ---
>  fs/f2fs/segment.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index c1a03b0857f9..57a81f9c8c14 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -848,9 +848,8 @@ static int issue_discard_thread(void *data)
>  	if (kthread_should_stop())
>  		return 0;
>  
> -	blk_start_plug(&plug);
> -
>  	mutex_lock(&dcc->cmd_lock);
> +	blk_start_plug(&plug);
>  	list_for_each_entry_safe(dc, tmp, pend_list, list) {
>  		f2fs_bug_on(sbi, dc->state != D_PREP);
>  
> @@ -860,6 +859,7 @@ static int issue_discard_thread(void *data)
>  		if (iter++ > DISCARD_ISSUE_RATE)
>  			break;
>  	}
> +	blk_finish_plug(&plug);
>  
>  	list_for_each_entry_safe(dc, tmp, wait_list, list) {
>  		if (dc->state == D_DONE)
> @@ -867,8 +867,6 @@ static int issue_discard_thread(void *data)
>  	}
>  	mutex_unlock(&dcc->cmd_lock);
>  
> -	blk_finish_plug(&plug);
> -
>  	iter = 0;
>  	congestion_wait(BLK_RW_SYNC, HZ/50);
>  
>