linux-kernel - Re: [PATCH] kbuild: Consolidate header generation from ASM offset information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170412013834.GE28657@google.com>
Date:   Tue, 11 Apr 2017 18:38:34 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghua.yu@...el.com>,
        Michal Marek <mmarek@...e.com>,
        Jan Kiszka <jan.kiszka@...mens.com>,
        Kieran Bingham <kieran.bingham@...aro.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-ia64@...r.kernel.org,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Grant Grundler <grundler@...omium.org>,
        Michael Davidson <md@...gle.com>,
        Greg Hackmann <ghackmann@...gle.com>
Subject: Re: [PATCH] kbuild: Consolidate header generation from ASM offset
 information

Hi Masahiro,

El Wed, Apr 12, 2017 at 09:03:28AM +0900 Masahiro Yamada ha dit:

> 2017-04-04 4:37 GMT+09:00 Matthias Kaehlcke <mka@...omium.org>:
> > Largely redundant code is used in different places to generate C headers
> > from offset information extracted from assembly language output.
> > Consolidate the code in a Makefile include and use this instead.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> 
> 
> Please move sed-y and filechk_offsets to scripts/Makefile.lib .
> (You may need to rename sed-y
> because arch/xtensa/kernel/Makefile uses this name.)
> 
> 
> We see various helpers in scripts/Makefile.lib,
> so I do not think we need to create a new file just for this one.
> 
> Then, please reuse it from arch/ia64/kernel/Makefile and scripts/mod/Makefile.
> Like this:
> 
> include/generated/nr-irqs.h: arch/$(SRCARCH)/kernel/nr-irqs.s FORCE
>         $(call filechk,offsets,__ASM_NR_IRQS_H__)
> 
> $(obj)/$(devicetable-offsets-file): $(obj)/devicetable-offsets.s FORCE
>         $(call filechk,offsets,__DEVICETABLE_OFFSETS_H__)

Thanks for your comments, I'll rework the patch accordingly.

Cheers

Matthias