linux-kernel - Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871ssx1z9x.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
Date:   Wed, 12 Apr 2017 10:22:34 -0400
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

Hi Florian,

Florian Fainelli <f.fainelli@...il.com> writes:

> On 04/11/2017 01:52 PM, Vivien Didelot wrote:
>> This patch moves as is the legacy DSA code from dsa.c to legacy.c,
>> except the few shared symbols which remain in dsa.c.
>> 
>> Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled,
>> which is true by default.
>> 
>> DSA drivers without legacy support don't need the probe function as well
>> as driver registration helpers anymore, so remove their definitions if
>> CONFIG_NET_DSA_LEGACY is disabled.
>> 
>> NET_DSA_MV88E6060 and NET_DSA_BCM_SF2 now depend on the legacy support.
>
> BCM_SF2 is not dependent on legacy support since it got converted to the
> new API in the past few months.

Oops, my bad. Fixing it.

> You may want to generate your patch with git format-patch -M to help
> detect renames/code movements.

I used --find-copies-harder -C for easier review but I can use -M.

Thanks,

        Vivien